-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc comments everywhere #41
Conversation
@magnet Also could use your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but now I'm starting to think about how to maintain a large number of tests of the kind sample_fb -> expected (code|ast)
. I'm not sure how rustc
does this, maybe @nagisa could weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall!
One thing that may be worth looking into is forwarding the comments to the IR layer when adding it to new types (e.g EnumVal
)
Ah yeah, let me do that. |
Tests for distinct output families are different tests, so it makes all the sense for them to be separate tests in the first place. |
I'd like to add even more of these, e.g fb -> Rust code (using We're getting larger and larger modules & would be happy splitting things up a bit, while keeping tests within modules. Opinions welcome 🙂 |
After tinkering some more with |
For namespaces I've created #44 since it's a fair amount of code and should be reviewed separately. |
@magnet @lovesegfault This could use another round of review, as I've done some refactoring. |
Closes #36