Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update data_source_name in configuration file #574

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Neaj-Morshad-101
Copy link
Contributor

@Neaj-Morshad-101 Neaj-Morshad-101 commented Aug 9, 2024

Getting invalid URL error because of this. Found the solution in https://github.com/xo/dburl documentation.
The example database connection URL that can be handled by dburl.Parse and dburl.Open:
sqlserver://user:[email protected]/dbname

I think we need to provide dbname in data_source_name

@burningalchemist
Copy link
Owner

I'd say dbname would be more relevant than master for the example DSN, as the string also supports instance name, which might be confusing.

Overall, I'm going to deprecate and remove this file eventually in favour of a proper static documentation website I work on in my free time.

Still, happy to merge the PR if you think it's useful. 👍

@burningalchemist burningalchemist changed the title Update data_source_name in configuration file docs: update data_source_name in configuration file Aug 9, 2024
@Neaj-Morshad-101
Copy link
Contributor Author

Updated with dbname

@burningalchemist burningalchemist merged commit 03f49c6 into burningalchemist:master Aug 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants