Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): ServiceMonitor namespace override #563

Merged

Conversation

dtjm
Copy link
Contributor

@dtjm dtjm commented Jul 19, 2024

if I set serviceMonitor.namespace, it overrides the namespace where the ServiceMonitor is deployed. However, the pod is deployed in the same namespace, so I'd like this to override the namespace in matchNamespace spec field also.

@burningalchemist
Copy link
Owner

burningalchemist commented Jul 19, 2024

Hey @dtjm, thanks for your contribution! 👍

Could you please also execute the following command as per our recommendation (as it contains additional templating):

After changing default Values, please execute make gen_docs located in helm folder to update the README.md file. Readme file is generated by the helm-docs tool, so make sure not to edit it manually.

@burningalchemist burningalchemist self-requested a review July 19, 2024 08:58
Copy link
Owner

@burningalchemist burningalchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run make gen_docs to render docs automatically and submit the changes to the PR.

@dtjm
Copy link
Contributor Author

dtjm commented Jul 19, 2024

Thank you @burningalchemist , sorry I failed to actually read the instructions =) I've pushed that new rendering in eb65d16.

@burningalchemist
Copy link
Owner

burningalchemist commented Jul 19, 2024

@dtjm No worries, thanks for adding the changes. 👍

@dtjm
Copy link
Contributor Author

dtjm commented Jul 19, 2024

👍🏽 thank you for making this code open source!

@burningalchemist burningalchemist changed the title helm: fix ServiceMonitor namespace override fix(helm): ServiceMonitor namespace override Jul 19, 2024
@burningalchemist burningalchemist merged commit 8ce8744 into burningalchemist:master Jul 19, 2024
4 checks passed
@burningalchemist
Copy link
Owner

v0.6.1 should be available shortly! 🚀

@dtjm dtjm deleted the servicemonitor-namespace branch July 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants