Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(helm): adjust the logic for serviceAccount creation #513

Merged
merged 2 commits into from
May 11, 2024

Conversation

burningalchemist
Copy link
Owner

@burningalchemist burningalchemist commented May 11, 2024

  • serviceAccount field is deprecated in favour of serviceAccountName;
  • serviceAccount.create should create a serviceAccount resource bound to the helm release name (which can be overriden, yet is consistent);
  • serviceAccount.name should allow users to reference a custom service account created outside of the helm release;
  • if create is false, and name is not set, serviceAccountName field falls back to default which is equal to not providing the serviceAccountName at all.

BREAKING CHANGE: from v0.5.0 serviceAccount sql-exporter is created by default. Can be disabled if needed to reference a custom serviceAccount object.

@burningalchemist burningalchemist changed the title fix!: adjust the logic for serviceAccount creation fix!(helm): adjust the logic for serviceAccount creation May 11, 2024
@burningalchemist burningalchemist merged commit 881da5b into master May 11, 2024
4 checks passed
@burningalchemist burningalchemist deleted the helm050 branch May 11, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant