fix: return partial results for multiple targets (#331)

burningalchemist · Sep 20, 2023 · 5e5096e · 5e5096e
1 parent 2f6e229
commit 5e5096e
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/cmd/sql_exporter/promhttp.go b/cmd/sql_exporter/promhttp.go
@@ -38,17 +38,13 @@ func ExporterHandlerFor(exporter sql_exporter.Exporter) http.Handler {
 		if err != nil {
 			if errors.Is(err, context.DeadlineExceeded) {
 				klog.Errorf("Timeout collecting metrics from target: %s", err)
-				http.Error(w, "Timeout collecting metrics from target, "+err.Error(), http.StatusInternalServerError)
-				return
 			}
 			if len(mfs) == 0 {
 				klog.Errorf("No metrics gathered: %s", err)
 				http.Error(w, "No metrics gathered, "+err.Error(), http.StatusInternalServerError)
 				return
 			}
 			klog.Errorf("Error gathering metrics: %s", err)
-			http.Error(w, "Error gathering metrics, "+err.Error(), http.StatusInternalServerError)
-			return
 		}
 
 		contentType := expfmt.Negotiate(req.Header)