Update later.js #38
Open
Update later.js #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was failing with test
var newDate = new Date('2014-02-28');
later.schedule({schedules: [{D:[1], M:[2], Y:[2014]},{D_a:[27], D_b:[29], M:[2], Y:[2014]}], exceptions: []}).isValid(newDate);
return !b || a.getTime() > b.getTime(); <-- a is null and so a.getTime() is blowing up
Bills fix is working a treat so far
| @@ -763,9 +763,9 @@ later = function() { | |||
| } | |||
| function compareFn(dir) { | |||
| return dir === "next" ? function(a, b) { | |||
| return !b || a.getTime() > b.getTime(); | |||
| return !a ? true : (!b || a.getTime() > b.getTime()); | |||
There was a problem hiding this comment.
You'll want to make these changes in schedule.js, around line 338. You can then run 'make' to build later.js and test it.
|
@oziee can you make these changes? |
|
Per my work with Bree, I have an updated fork of this package called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was failing with test
var newDate = new Date('2014-02-28');
later.schedule({schedules: [{D:[1], M:[2], Y:[2014]},{D_a:[27], D_b:[29], M:[2], Y:[2014]}], exceptions: []}).isValid(newDate);
return !b || a.getTime() > b.getTime(); <-- a is null and so a.getTime() is blowing up
Bills fix is working a treat so far