Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dependencies): overriding bugged rollup version #1614

Closed
wants to merge 1 commit into from

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Oct 2, 2024

Description

there appears to be a bug in a recent version of rollup that's causing local build failures. a clean npm install with the latest version works, so it seems to be an incompatibility with a previous version of one of our other dependencies. rolling rollup back to 4.11.0 for now and will update all of our dependencies and remove this override with the next minor release.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@dvoegelin dvoegelin self-assigned this Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Visit the preview URL for this PR (updated for commit a7bbec4):

https://novo-elements--pr1614-override-rollup-nil1zj9v.web.app

(expires Wed, 09 Oct 2024 18:07:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@dvoegelin
Copy link
Collaborator Author

going to close this, moving forward with the workaround to simply delete node_modules and re npm install.

@dvoegelin dvoegelin closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant