Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TabbedGroupPicker): Emit selected values on cancel #1613

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

fix(TabbedGroupPicker): Emit selected values on cancel #1613

wants to merge 5 commits into from

Conversation

monroepe
Copy link
Collaborator

@monroepe monroepe commented Oct 1, 2024 •
edited
Loading

Description

  • Updated Tabbed Group Picker to emit the current tabs (which are reverted to previously applied state already) when cancel is clicked.
  • Added a demo for Tabbed Group Picker with a footer that takes advantage of the emitted value on cancel.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 9e26e42):

https://novo-elements--pr1613-f-tabbed-group-cance-1k4f2rms.web.app

(expires Wed, 09 Oct 2024 18:23:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@monroepe monroepe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@monroepe