Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tooltip): Add closeOnClick input to pass to Tooltip #1598

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix(Tooltip): Add closeOnClick input to pass to Tooltip #1598

merged 3 commits into from
Sep 10, 2024

Conversation

s-russi
Copy link
Collaborator

@s-russi s-russi commented Sep 9, 2024 •
edited
Loading

Description

added a new input closeOnClick and a close event which is executed if closeOnClick is true

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit f8a20b5):

https://novo-elements--pr1598-f-bh-90263-oyxa6ahz.web.app

(expires Tue, 17 Sep 2024 19:10:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

dvoegelin
dvoegelin previously approved these changes Sep 9, 2024
View reviewed changes
ndickerson
ndickerson previously approved these changes Sep 9, 2024
View reviewed changes
@s-russi s-russi dismissed stale reviews from ndickerson and dvoegelin via bcbdab9 September 10, 2024 16:14
@dvoegelin dvoegelin merged commit 0e38db0 into next Sep 10, 2024
5 checks passed
@dvoegelin dvoegelin deleted the f/BH-90263 branch September 10, 2024 19:28
@dvoegelin dvoegelin mentioned this pull request Sep 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoegelin dvoegelin dvoegelin approved these changes

@davidkbh davidkbh davidkbh approved these changes

@ndickerson ndickerson ndickerson left review comments

Assignees

@s-russi s-russi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s-russi @ndickerson @dvoegelin @davidkbh @russi-sinha