Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Update keyword types #1595

Merged
merged 4 commits into from
Sep 4, 2024
Merged

fix(types): Update keyword types #1595

merged 4 commits into from
Sep 4, 2024

Conversation

ndickerson
Copy link
Member

@ndickerson ndickerson commented Aug 27, 2024

Description

Updating the types to include the new optional "uniqueName" and making the exclude optional, which is backwards compatible and safe because testing exclude using a falsy check will work for "false" or "undefined" or "null". The exclude is not guaranteed to be there if the data is coming in from an outside call. Likewise, uniqueName is not guaranteed from the outside call yet, but should be there going forward, so optional for now.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

github-actions bot commented Aug 27, 2024

Visit the preview URL for this PR (updated for commit f2fc701):

https://novo-elements--pr1595-keyword-types-b80q8kxw.web.app

(expires Fri, 06 Sep 2024 16:31:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@ndickerson ndickerson merged commit 550de2d into next Sep 4, 2024
6 checks passed
@ndickerson ndickerson deleted the keyword-types branch September 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants