feat(Tiles): restyling the novo-tiles component to be more legible #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e updates, overlay backdrop clicks and criteria value changes (#1568) * feat(Data Table): Allow skipping explicit table.state update * feat(modals): added novo-dropdown to ng-content select options in novo-notification * skipUpdate skips state clear entirely * Select null check error fix * feat(Overlay): added backDropClick event emitter * updated all clear-button methods to account for new emitOnly input * added unsavedChanges to preferences interface * BooleanInput emitOnly * Allow for value changes to text criteria to dirty the form * Allow for value changes to text criteria to dirty the form * moved DataTableSavedSearchOwner interface to novo-elements * revert null checks from Select.ts, based on MR comment --------- Co-authored-by: Nathan Dickerson <[email protected]>
* BES-169: Fix Toast UI position & padding * BH-88988: Fix Toast UI animation position & padding * BH-88988: Added Toast UI style & close examples * feat(Data Table, Overlay, CriteriaBuilder): Fixes for data table state updates, overlay backdrop clicks and criteria value changes (#1568) * feat(Data Table): Allow skipping explicit table.state update * feat(modals): added novo-dropdown to ng-content select options in novo-notification * skipUpdate skips state clear entirely * Select null check error fix * feat(Overlay): added backDropClick event emitter * updated all clear-button methods to account for new emitOnly input * added unsavedChanges to preferences interface * BooleanInput emitOnly * Allow for value changes to text criteria to dirty the form * Allow for value changes to text criteria to dirty the form * moved DataTableSavedSearchOwner interface to novo-elements * revert null checks from Select.ts, based on MR comment --------- Co-authored-by: Nathan Dickerson <[email protected]> --------- Co-authored-by: Tom Fechtner <[email protected]> Co-authored-by: Dan Voegelin <[email protected]> Co-authored-by: Kevin Florian <[email protected]> Co-authored-by: Nathan Dickerson <[email protected]>
…ndition builder (#1573) * feat(Criteria Builder): Add location radius option to the address criteria * Explicit dirtying of form * Updated demo * Enable form updates * Updated Demo * Fix CSS for dropdown * Listen to updates to the radius * Fix an error and unit tests * Update example --------- Co-authored-by: Nathan Dickerson <[email protected]>
fix(TabbedGroupPicker): Fix scroll behavior
* feat(Autocomplete): Add an attribute option to immediately activate the first result for autocomplete * test(Autocomplete): Add unit tests for autocomplete component --------- Co-authored-by: Dan Voegelin <[email protected]>
Co-authored-by: Dan Voegelin <[email protected]>
* fix(Overlay): Drag events close overlays * regenerating documentation.json after rebase --------- Co-authored-by: Dan Voegelin <[email protected]>
|
Visit the preview URL for this PR (updated for commit c665149): https://novo-elements--pr1590-tile-restyle-e3v7qj7t.web.app (expires Mon, 02 Sep 2024 15:27:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
ndickerson
previously approved these changes
Aug 21, 2024
dvoegelin
dismissed
ndickerson’s stale review
The merge-base changed after approval.
monroepe
previously approved these changes
Aug 26, 2024
ndickerson
approved these changes
Aug 26, 2024
monroepe
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the tiles component wasn't as readable as we'd like, so this restyle is an attempt to address that. we added some new features but other than those it should be functionally identical to the original component with the exception of the tile
<div>being replaced with a<button>. the new features include:Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots