fixing bug with untyped properties on current value throwing errors w…

…hen switching conditionTypes
bullhorn · Aug 30, 2024 · 9baa213 · 9baa213
1 parent a9f17c8
commit 9baa213
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...cts/novo-elements/src/elements/query-builder/condition-group/condition-group.component.ts b/...cts/novo-elements/src/elements/query-builder/condition-group/condition-group.component.ts
@@ -74,7 +74,9 @@ export class ConditionGroupComponent implements OnInit, OnDestroy {
       this.parentForm.controls[name] = this.parentForm.controls[this.controlName];
       delete this.parentForm.controls[this.controlName];
       this.controlName = name;
-      this.parentForm.get(this.controlName).setValue(current);
+      // scrub properties not on control
+      const currentStrict = current.map((item) => (({ conditionType, field, operator, scope, value, ...rest }) => ({ conditionType, field, operator, scope, value }))(item));
+      this.parentForm.get(this.controlName)?.setValue(currentStrict);
       this.cdr.markForCheck();
     }
   }