Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix total count of filter options for issue #525 #528

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ericflores108
Copy link

For filter options with over 500+ records, the totals in the filter are wrong. This PR should resolve issue #525

Additions / Removals

  • Pull more records in the getCurrentJobIds function. Return records.
  • In the sidebar component, if total is greater than 500+ records, there will be a bad request due to overload of data. To fix this, I sliced initial 500 records. If the user removes the search or filter results are more than 500+ records, the filter will be reset.
  • In the sidebar filter component, I changed "res.data.map" to "res.map" as I have changed getCurrentJobIds to return all records.

Testing

Screenshots

image
image
image

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the contributing guide
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices

@johanvanwambeke
Copy link

So this works, but it breaks normal search. Because your search looks like this:
https://public-rest70.bullhornstaffing.com/rest-services/A4VPG0/search/JobOrder?start=0&query=(isOpen:1)%20AND%20(isDeleted:0)%20AND%20(businessSectors.id:1100000%20OR%20businessSectors.id:1100001)%20AND%20(id:13%20OR%20id:16%20OR%20id:17%20OR%20id:18%20OR%20id:71%20OR%20id:72%20OR%20id:75%20OR%20id:76%20OR%20id:78%20OR%20id:82%20OR%20id:85%20OR%20id:88%20OR%20id:90%20OR%20id:106%20OR%20id:124%20OR%20id:129%20OR%20id:130%20OR%20id:131%20OR%20id:132%20OR%20id:133%20OR%20id:134%20OR%20id:135%20OR%20id:136%20OR%20id:137%20OR%20id:138%20OR%20id:140%20OR%20id:141%20OR%20id:143%20OR%20id:144%20OR%20id:145%20OR%20id:147%20OR%20id:148%20OR%20id:149%20OR%20id:150%20OR%20id:151%20OR%20id:152%20OR%20id:153%20OR%20id:154%20OR%20id:155%20OR%20id:156%20OR%20id:157%20OR%20id:158%20OR%20id:159%20OR%20id:161%20OR%20id:162%20OR%20id:163%20OR%20id:164%20OR%20id:165%20OR%20id:166%20OR%20id:167%20OR%20id:169%20OR%20id:170%20OR%20id:171%20OR%20id:172%20OR%20id:173%20OR%20id:174%20OR%20id:175%20OR%20id:181%20OR%20id:182%20OR%20id:183%20OR%20id:184%20OR%20id:185%20OR%20id:186%20OR%20id:187%20OR%20id:188%20OR%20id:190%20OR%20id:191%20OR%20id:193%20OR%20id:194%20OR%20id:196%20OR%20id:198%20OR%20id:199%20OR%20id:201%20OR%20id:204%20OR%20id:206%20OR%20id:207%20OR%20id:208%20OR%20id:210%20OR%20id:211%20OR%20id:224%20OR%20id:227%20OR%20id:228%20OR%20id:231%20OR%20id:232%20OR%20id:233%20OR%20id:245%20OR%20id:246%20OR%20id:247%20OR%20id:249%20OR%20id:250%20OR%20id:251%20OR%20id:253%20OR%20id:255%20OR%20id:258%20OR%20id:260%20OR%20id:261%20OR%20id:262%20OR%20id:263%20OR%20id:264%20OR%20id:265%20OR%20id:266%20OR%20id:267%20OR%20id:268%20OR%20id:269%20OR%20id:270%20OR%20id:271%20OR%20id:272%20OR%20id:273%20OR%20id:274%20OR%20id:275%20OR%20id:276%20OR%20id:277%20OR%20id:278%20OR%20id:280%20OR%20id:281%20OR%20id:282%20OR%20id:283%20OR%20id:284%20OR%20id:285%20OR%20id:286%20OR%20id:287%20OR%20id:288%20OR%20id:289%20OR%20id:291%20OR%20id:292%20OR%20id:293%20OR%20id:294%20OR%20id:295%20OR%20id:296%20OR%20id:297%20OR%20id:298%20OR%20id:299%20OR%20id:300%20OR%20id:301%20OR%20id:302%20OR%20id:303%20OR%20id:304%20OR%20id:306%20OR%20id:307%20OR%20id:308%20OR%20id:309%20OR%20id:310%20OR%20id:311%20OR%20id:312%20OR%20id:313%20OR%20id:314%20OR%20id:315%20OR%20id:316%20OR%20id:317%20OR%20id:318%20OR%20id:319%20OR%20id:320%20OR%20id:321%20OR%20id:322%20OR%20id:323%20OR%20id:324%20OR%20id:326%20OR%20id:327%20OR%20id:330%20OR%20id:332%20OR%20id:333%20OR%20id:334%20OR%20id:335%20OR%20id:336%20OR%20id:337%20OR%20id:339%20OR%20id:340%20OR%20id:341%20OR%20id:342%20OR%20id:343%20OR%20id:346%20OR%20id:348%20OR%20id:349%20OR%20id:368%20OR%20id:369%20OR%20id:370%20OR%20id:371%20OR%20id:372%20OR%20id:373%20OR%20id:374%20OR%20id:375%20OR%20id:376%20OR%20id:377%20OR%20id:378%20OR%20id:379%20OR%20id:380%20OR%20id:381%20OR%20id:382%20OR%20id:383%20OR%20id:385%20OR%20id:386%20OR%20id:390%20OR%20id:391%20OR%20id:394%20OR%20id:395%20OR%20id:396%20OR%20id:397%20OR%20id:400%20OR%20id:401%20OR%20id:402%20OR%20id:403%20OR%20id:405%20OR%20id:406%20OR%20id:407%20OR%20id:409%20OR%20id:410%20OR%20id:412%20OR%20id:414%20OR%20id:415%20OR%20id:416%20OR%20id:417%20OR%20id:422%20OR%20id:423%20OR%20id:424%20OR%20id:427%20OR%20id:429%20OR%20id:431%20OR%20id:432%20OR%20id:433%20OR%20id:441%20OR%20id:442%20OR%20id:443%20OR%20id:444%20OR%20id:445%20OR%20id:446%20OR%20id:447%20OR%20id:448%20OR%20id:449%20OR%20id:451%20OR%20id:452%20OR%20id:453%20OR%20id:455%20OR%20id:456%20OR%20id:457%20OR%20id:458%20OR%20id:459%20OR%20id:460%20OR%20id:462%20OR%20id:464%20OR%20id:465%20OR%20id:466%20OR%20id:468%20OR%20id:469%20OR%20id:470%20OR%20id:471%20OR%20id:472%20OR%20id:473%20OR%20id:476%20OR%20id:477%20OR%20id:478%20OR%20id:479%20OR%20id:480%20OR%20id:481%20OR%20id:482%20OR%20id:483%20OR%20id:484%20OR%20id:485%20OR%20id:486%20OR%20id:487%20OR%20id:488%20OR%20id:489%20OR%20id:490%20OR%20id:491%20OR%20id:492%20OR%20id:493%20OR%20id:495%20OR%20id:497%20OR%20id:498%20OR%20id:499%20OR%

And so on ... breaking the functionality.

@ericflores108 ericflores108 marked this pull request as draft December 11, 2023 20:38
@ericflores108 ericflores108 marked this pull request as ready for review January 10, 2024 15:40
@ericflores108
Copy link
Author

So this works, but it breaks normal search. Because your search looks like this: https://public-rest70.bullhornstaffing.com/rest-services/A4VPG0/search/JobOrder?start=0&query=(isOpen:1)%20AND%20(isDeleted:0)%20AND%20(businessSectors.id:1100000%20OR%20businessSectors.id:1100001)%20AND%20(id:13%20OR%20id:16%20OR%20id:17%20OR%20id:18%20OR%20id:71%20OR%20id:72%20OR%20id:75%20OR%20id:76%20OR%20id:78%20OR%20id:82%20OR%20id:85%20OR%20id:88%20OR%20id:90%20OR%20id:106%20OR%20id:124%20OR%20id:129%20OR%20id:130%20OR%20id:131%20OR%20id:132%20OR%20id:133%20OR%20id:134%20OR%20id:135%20OR%20id:136%20OR%20id:137%20OR%20id:138%20OR%20id:140%20OR%20id:141%20OR%20id:143%20OR%20id:144%20OR%20id:145%20OR%20id:147%20OR%20id:148%20OR%20id:149%20OR%20id:150%20OR%20id:151%20OR%20id:152%20OR%20id:153%20OR%20id:154%20OR%20id:155%20OR%20id:156%20OR%20id:157%20OR%20id:158%20OR%20id:159%20OR%20id:161%20OR%20id:162%20OR%20id:163%20OR%20id:164%20OR%20id:165%20OR%20id:166%20OR%20id:167%20OR%20id:169%20OR%20id:170%20OR%20id:171%20OR%20id:172%20OR%20id:173%20OR%20id:174%20OR%20id:175%20OR%20id:181%20OR%20id:182%20OR%20id:183%20OR%20id:184%20OR%20id:185%20OR%20id:186%20OR%20id:187%20OR%20id:188%20OR%20id:190%20OR%20id:191%20OR%20id:193%20OR%20id:194%20OR%20id:196%20OR%20id:198%20OR%20id:199%20OR%20id:201%20OR%20id:204%20OR%20id:206%20OR%20id:207%20OR%20id:208%20OR%20id:210%20OR%20id:211%20OR%20id:224%20OR%20id:227%20OR%20id:228%20OR%20id:231%20OR%20id:232%20OR%20id:233%20OR%20id:245%20OR%20id:246%20OR%20id:247%20OR%20id:249%20OR%20id:250%20OR%20id:251%20OR%20id:253%20OR%20id:255%20OR%20id:258%20OR%20id:260%20OR%20id:261%20OR%20id:262%20OR%20id:263%20OR%20id:264%20OR%20id:265%20OR%20id:266%20OR%20id:267%20OR%20id:268%20OR%20id:269%20OR%20id:270%20OR%20id:271%20OR%20id:272%20OR%20id:273%20OR%20id:274%20OR%20id:275%20OR%20id:276%20OR%20id:277%20OR%20id:278%20OR%20id:280%20OR%20id:281%20OR%20id:282%20OR%20id:283%20OR%20id:284%20OR%20id:285%20OR%20id:286%20OR%20id:287%20OR%20id:288%20OR%20id:289%20OR%20id:291%20OR%20id:292%20OR%20id:293%20OR%20id:294%20OR%20id:295%20OR%20id:296%20OR%20id:297%20OR%20id:298%20OR%20id:299%20OR%20id:300%20OR%20id:301%20OR%20id:302%20OR%20id:303%20OR%20id:304%20OR%20id:306%20OR%20id:307%20OR%20id:308%20OR%20id:309%20OR%20id:310%20OR%20id:311%20OR%20id:312%20OR%20id:313%20OR%20id:314%20OR%20id:315%20OR%20id:316%20OR%20id:317%20OR%20id:318%20OR%20id:319%20OR%20id:320%20OR%20id:321%20OR%20id:322%20OR%20id:323%20OR%20id:324%20OR%20id:326%20OR%20id:327%20OR%20id:330%20OR%20id:332%20OR%20id:333%20OR%20id:334%20OR%20id:335%20OR%20id:336%20OR%20id:337%20OR%20id:339%20OR%20id:340%20OR%20id:341%20OR%20id:342%20OR%20id:343%20OR%20id:346%20OR%20id:348%20OR%20id:349%20OR%20id:368%20OR%20id:369%20OR%20id:370%20OR%20id:371%20OR%20id:372%20OR%20id:373%20OR%20id:374%20OR%20id:375%20OR%20id:376%20OR%20id:377%20OR%20id:378%20OR%20id:379%20OR%20id:380%20OR%20id:381%20OR%20id:382%20OR%20id:383%20OR%20id:385%20OR%20id:386%20OR%20id:390%20OR%20id:391%20OR%20id:394%20OR%20id:395%20OR%20id:396%20OR%20id:397%20OR%20id:400%20OR%20id:401%20OR%20id:402%20OR%20id:403%20OR%20id:405%20OR%20id:406%20OR%20id:407%20OR%20id:409%20OR%20id:410%20OR%20id:412%20OR%20id:414%20OR%20id:415%20OR%20id:416%20OR%20id:417%20OR%20id:422%20OR%20id:423%20OR%20id:424%20OR%20id:427%20OR%20id:429%20OR%20id:431%20OR%20id:432%20OR%20id:433%20OR%20id:441%20OR%20id:442%20OR%20id:443%20OR%20id:444%20OR%20id:445%20OR%20id:446%20OR%20id:447%20OR%20id:448%20OR%20id:449%20OR%20id:451%20OR%20id:452%20OR%20id:453%20OR%20id:455%20OR%20id:456%20OR%20id:457%20OR%20id:458%20OR%20id:459%20OR%20id:460%20OR%20id:462%20OR%20id:464%20OR%20id:465%20OR%20id:466%20OR%20id:468%20OR%20id:469%20OR%20id:470%20OR%20id:471%20OR%20id:472%20OR%20id:473%20OR%20id:476%20OR%20id:477%20OR%20id:478%20OR%20id:479%20OR%20id:480%20OR%20id:481%20OR%20id:482%20OR%20id:483%20OR%20id:484%20OR%20id:485%20OR%20id:486%20OR%20id:487%20OR%20id:488%20OR%20id:489%20OR%20id:490%20OR%20id:491%20OR%20id:492%20OR%20id:493%20OR%20id:495%20OR%20id:497%20OR%20id:498%20OR%20id:499%20OR%

And so on ... breaking the functionality.

@johanvanwambeke can you take a look at the updateFilter and handleJobIdsOnSuccess? Perhaps we can only limit this to 500 until the search is refined. Let me know your thoughts. This also came up in the getAvailableFilterOptions function (where "ids IN..." is too long) and has been revised.

@ericflores108 ericflores108 marked this pull request as draft March 25, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants