Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): Updated Generation to EntityModelStreamer... #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bvkimball
Copy link
Contributor

Probably need to run in Jenkins nightly and do a diff against the results, or open PR if there are changes.

@bvkimball bvkimball self-assigned this Apr 12, 2021
@bvkimball bvkimball added enhancement New feature or request help wanted Extra attention is needed labels Apr 12, 2021
case "Timestamp":
data.properties.push({
name: field.fieldName,
type: "Date",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dates are not actually represented as Date objects in REST - they are returned as the millisecond timestamp, which should be of type number, not Date.

case "byte[]":
data.properties.push({
name: field.fieldName,
type: "Strings",
Copy link
Member

@ndickerson ndickerson Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only fields that require the Strings type of string or string[] are fields that start with customText. Configuring a field outside of a custom text field to be a multi-value string array in field maps would be either extremely rare, or a misconfig. For instance, the status string field could be configured to be a multi-value by a customer, but that would break any workflows that rely on status being a single value string. We can add logic that only applies the Strings to fields that are of the format: customText[n]. We don't need to apply this to customTextBlock[n] because those fields should not be configured to be multi-value - they are text areas or html editor blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants