Accept only textual subtitle codecs

buganime/buganime.py

@@ -19,6 +19,8 @@
 OUTPUT_DIR = os.getenv('BUGANIME_OUTPUT_DIR', '')
 UPSCALE_MUTEX_NAME = 'anime4kconvert'
 
+SUPPORTED_SUBTITLE_CODECS = ('ass', 'subrip')
+
 
 @contextlib.contextmanager
 def lock_mutex(name: str) -> Iterator[None]:
@@ -69,7 +71,8 @@ def _get_subtitle_stream_index() -> int:
         for i, stream in enumerate(subtitle_streams):
             match stream:
                 case {'tags': {'language': str(lang)}} if lang in ('en', 'eng'):
-                    if all(x not in stream['tags'].get('title', '').upper() for x in ('S&S', 'SIGNS', 'FORCED')):
+                    if all(x not in stream['tags'].get('title', '').upper() for x in ('S&S', 'SIGNS', 'FORCED')) and \
+                       stream['codec_name'].lower() in SUPPORTED_SUBTITLE_CODECS:
                         relevant_streams.append((i, stream))
         if not relevant_streams:
             if len(subtitle_streams) == 1:
@@ -141,10 +144,18 @@ def process_file(input_path: str) -> None:
     logging.info('ffprobe %s wrote %s, %s', str(proc.args), proc.stderr, proc.stdout)
     video_info = parse_streams(json.loads(proc.stdout)['streams'])
 
-    with lock_mutex(name=UPSCALE_MUTEX_NAME):
-        logging.info('Running Upscaler')
-        asyncio.run(transcode.Transcoder(input_path=input_path, output_path=output_path, height_out=2160, width_out=3840, video_info=video_info).run())
-        logging.info('Upscaler for %s finished', input_path)
+    try:
+        with lock_mutex(name=UPSCALE_MUTEX_NAME):
+            logging.info('Running Upscaler')
+            asyncio.run(transcode.Transcoder(input_path=input_path, output_path=output_path, height_out=2160, width_out=3840, video_info=video_info).run())
+            logging.info('Upscaler for %s finished', input_path)
+    except Exception:
+        logging.warning('Upscaler for %s failed. Deleting output %s', input_path, output_path)
+        try:
+            os.unlink(output_path)
+        except Exception:
+            pass
+        raise
 
 
 def process_path(input_path: str) -> None:

dev-requirements.txt

@@ -7,5 +7,4 @@ mypy
 tqdm-stubs
 types-retry
 types-requests
-torch<2.3.0  # Due to https://github.com/pytorch/pytorch/issues/124897
 -r requirements.txt

requirements.txt

@@ -2,7 +2,7 @@ pywin32
 opencv-python
 requests
 tqdm
-numpy
+numpy<2.0.0,>=1.16.0  # https://github.com/pytorch/pytorch/issues/78341
 retry
 torch
 torchvision