Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field numbers for v1 ListLabelHistoryRequest #84

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix field numbers for v1 ListLabelHistoryRequest #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions buf/registry/module/v1/label_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
repeated Label labels = 2;
}

message ListLabelHistoryRequest {

Check failure on line 129 in buf/registry/module/v1/label_service.proto

View workflow job for this annotation

GitHub Actions / breaking 

Previously present field "7" with name "start_commit_id" on message "ListLabelHistoryRequest" was deleted without reserving the name "start_commit_id".

Check failure on line 129 in buf/registry/module/v1/label_service.proto

View workflow job for this annotation

GitHub Actions / breaking 

Previously present field "7" with name "start_commit_id" on message "ListLabelHistoryRequest" was deleted without reserving the number "7".
// The list order.
enum Order {
ORDER_UNSPECIFIED = 0;
Expand Down Expand Up @@ -159,11 +159,11 @@
// Only return Commits that have one of these CommitCheckStatus values for this label.
//
// If not set, Commits with any CommitCheckStatus value are returned.
repeated CommitCheckStatus commit_check_statuses = 6 [(buf.validate.field).repeated.items.enum.defined_only = true];
repeated CommitCheckStatus commit_check_statuses = 5 [(buf.validate.field).repeated.items.enum.defined_only = true];
// The Commit id to start from.
//
// It is an error to provide a Commit id that doesn't exist on the Label.
string start_commit_id = 7 [
string start_commit_id = 6 [

Check failure on line 166 in buf/registry/module/v1/label_service.proto

View workflow job for this annotation

GitHub Actions / breaking 

Field "6" with name "start_commit_id" on message "ListLabelHistoryRequest" changed option "json_name" from "commitCheckStatuses" to "startCommitId".

Check failure on line 166 in buf/registry/module/v1/label_service.proto

View workflow job for this annotation

GitHub Actions / breaking 

Field "6" on message "ListLabelHistoryRequest" changed label from "repeated" to "optional".

Check failure on line 166 in buf/registry/module/v1/label_service.proto

View workflow job for this annotation

GitHub Actions / breaking 

Field "6" on message "ListLabelHistoryRequest" changed type from "enum" to "string". See https://developers.google.com/protocol-buffers/docs/proto3#updating for wire compatibility rules and https://developers.google.com/protocol-buffers/docs/proto3#json for JSON compatibility rules.

Check failure on line 166 in buf/registry/module/v1/label_service.proto

View workflow job for this annotation

GitHub Actions / breaking 

Field "6" on message "ListLabelHistoryRequest" changed name from "commit_check_statuses" to "start_commit_id".
(buf.validate.field).string.uuid = true,
(buf.validate.field).ignore = IGNORE_IF_UNPOPULATED
];
Expand Down
Loading