Add start_commit_id to ListLabelHistoryRequest #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmultimedio
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
For context: we already have the property that a commit can be in the label history just once, so this is reasonable to me. Wdyt @saquibmian ?
bufdev
reviewed
Mar 1, 2024
nicksnyder
changed the title
bufdev
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To view a diff for a commit on a label we need to be able to get the previous commit on that label. Added
start_commit_idso we can fetch the history starting at the desired commit and using a page size of 2 can also get the previous commit.