Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert legacy.federation.v1beta1, module.v1beta1 to module.v1beta1, module.v1 #79

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Feb 28, 2024

This PR does a bunch of moves and updates:

  • Moves buf.registry.module.v1beta1 to buf.registry.module.v1.
  • Moves buf.registry.legacy.federation.v1beta1 to buf.registry.module.v1beta1.
  • Copies the types not in the old buf.registry.legacy.federation.v1beta1 into the new buf.registry.module.v1beta1.
  • Moves buf.registry.owner.v1beta1 to buf.registry.owner.v1.

The rest of the updates are referenced in terms of their new package location, not old package location:

  • Removes registry from v1beta1.ResourceRef, instead creating a wrapper GetGraphRequest.ResourceRef message that contains a registry field. We only need/want registry to be added to ResourceRef for this specific RPC.
  • Removes v1_buf_yaml_file, v1_buf_lock_file from both v1beta1 and v1 UploadRequests.
  • Removes digest_type for all v1 RPC request messages.
  • Removes DIGEST_TYPE_B4 in v1.
  • Removes v1_buf_yaml_file, v1_buf_lock_file from v1 DownloadResponse.
  • Removes the required market for v1_buf_yaml_file from v1beta1 DownloadResponse.

The result is a v1beta1 module API that allows for federation and B4 digests, and a cleaned-up v1 module API that only has what we need going forward.

Replaces #73.

@bufdev
Copy link
Member Author

bufdev commented Feb 28, 2024

@bufdev bufdev merged commit 0971f26 into main Feb 29, 2024
9 checks passed
@bufdev bufdev deleted the v1beta1-v1 branch February 29, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants