Move DepRefs and DigestType to top-level #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's primary purpose is to remove the need to specify dependencies between Contents on Upload, and to move external dependencies to the top-level of the UploadRequest. We do not need to manually specify dependencies between Contents, as this is implicitly done via .proto imports. We also want to make sure that for a given set of Contents, there is exactly one dependency Commit ID for a given Module. This matches what we have in Workspaces. The API will no longer enable uploading multiple Workspaces in one RPC, but we see no use case for this.
This PR also moves DigestType to the top-level of DownloadRequest, to match the other RPCs.