-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Plugin specification #132
Changes from 43 commits
e2a11ff
aa08ddf
2577109
2a1a374
861779d
badc37d
fa7e531
c5e3a78
0eac937
a82217d
dff06aa
adb18e6
69b571b
0208156
a3472e1
af0c906
df121ef
6887aab
c0a6fdc
7741a6b
365a2e4
b34ff09
681ee14
bab5cf2
a7468f6
0badaec
b1f3222
3e44a69
fd48e8f
428ed38
04cb0ab
69c0d42
ab84720
38293c9
b687e13
9af8a88
d9ba013
a801d90
6813f20
4282fe1
398d8e0
304e859
c47e631
2e7c067
624adc0
b3ac2f4
f6f7205
3dee9d4
1782bc5
45eb887
dea5e2a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
# Generated by buf. DO NOT EDIT. | ||
version: v2 | ||
deps: | ||
- name: buf.build/bufbuild/bufplugin | ||
commit: 42bdb4b676254830a221d52d10bf17be | ||
digest: b5:c9fb96550e52b1b899f667d2371d2aee37b4b5b0d8e21d83dd620207d466f3a95b96fc072fe9a49785da293f1fe379f0b4ac8ce054b6a1cedcafba8f2145d086 | ||
- name: buf.build/bufbuild/protovalidate | ||
commit: b983156c5e994cc9892e0ce3e64e17e0 | ||
digest: b5:a02a4a5a0a9306cf1391d17e8811bbd6a0dbd0e0e29ddfc34b9d103311164974472d43627c3d63e6a8abaffd6c7a301c4f7965bbab2dc56f7f7812429a84b812 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
// Copyright 2023-2024 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package buf.registry.plugin.v1beta1; | ||
|
||
import "buf/registry/priv/extension/v1beta1/extension.proto"; | ||
import "buf/validate/validate.proto"; | ||
import "google/protobuf/timestamp.proto"; | ||
|
||
option go_package = "buf.build/gen/go/bufbuild/registry/protocolbuffers/go/buf/registry/plugin/v1beta1"; | ||
|
||
// A collection for a Plugin. | ||
// | ||
// These collections help organize plugins based on their functionality or ecosystem. | ||
message Collection { | ||
option (buf.registry.priv.extension.v1beta1.message).response_only = true; | ||
|
||
// The id of the Collection. | ||
string id = 1 [ | ||
(buf.validate.field).required = true, | ||
(buf.validate.field).string.tuuid = true | ||
]; | ||
// The time the Collection was created on the BSR. | ||
google.protobuf.Timestamp create_time = 2 [(buf.validate.field).required = true]; | ||
// The last time the Label was updated on the BSR. | ||
google.protobuf.Timestamp update_time = 3 [(buf.validate.field).required = true]; | ||
// The name of the Collection. | ||
// | ||
// Unique within a BSR instance. | ||
string name = 4 [ | ||
(buf.validate.field).required = true, | ||
(buf.validate.field).string.max_len = 250 | ||
]; | ||
// The configurable description of the Collection. | ||
string description = 5 [(buf.validate.field).string.max_len = 350]; | ||
} | ||
|
||
// CollectionRef is a reference to a Collection, either an id or a name. | ||
message CollectionRef { | ||
option (buf.registry.priv.extension.v1beta1.message).request_only = true; | ||
|
||
oneof value { | ||
option (buf.validate.oneof).required = true; | ||
// The id of the Collection. | ||
string id = 1 [(buf.validate.field).string.tuuid = true]; | ||
// The name of the Collection. | ||
string name = 2 [(buf.validate.field).string = { | ||
min_len: 2 | ||
max_len: 100 | ||
}]; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright 2023-2024 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package buf.registry.plugin.v1beta1; | ||
|
||
option go_package = "buf.build/gen/go/bufbuild/registry/protocolbuffers/go/buf/registry/plugin/v1beta1"; | ||
|
||
// Operate on Collections. | ||
service CollectionService { | ||
// Get Collections. | ||
rpc GetCollections(GetCollectionsRequest) returns (GetCollectionsResponse) { | ||
option idempotency_level = NO_SIDE_EFFECTS; | ||
} | ||
// List Collections for a given Plugin. | ||
rpc ListCollections(ListCollectionsRequest) returns (ListCollectionsResponse) { | ||
option idempotency_level = NO_SIDE_EFFECTS; | ||
} | ||
} | ||
|
||
message GetCollectionsRequest {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's up with these? |
||
message GetCollectionsResponse {} | ||
|
||
message ListCollectionsRequest {} | ||
message ListCollectionsResponse {} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
// Copyright 2023-2024 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package buf.registry.plugin.v1beta1; | ||
|
||
import "buf/plugin/info/v1/plugin_info.proto"; | ||
import "buf/registry/plugin/v1beta1/digest.proto"; | ||
import "buf/registry/priv/extension/v1beta1/extension.proto"; | ||
import "buf/validate/validate.proto"; | ||
import "google/protobuf/timestamp.proto"; | ||
|
||
option go_package = "buf.build/gen/go/bufbuild/registry/protocolbuffers/go/buf/registry/plugin/v1beta1"; | ||
|
||
// A commit on a specific Plugin. | ||
// | ||
// Commits are immutable. | ||
// | ||
// Many Commits may be associated with one Digest. | ||
// | ||
// Not that the Digest returned on a Commit depends on the requested DigestType in the RPC that | ||
// returned the Commit. | ||
message Commit { | ||
option (buf.registry.priv.extension.v1beta1.message).response_only = true; | ||
|
||
// The id of the Commit. | ||
string id = 1 [ | ||
(buf.validate.field).required = true, | ||
(buf.validate.field).string.tuuid = true | ||
]; | ||
// The time the Commit was pushed to the BSR. | ||
// | ||
// Commits are immutable, so there is no corresponding update_time. | ||
google.protobuf.Timestamp create_time = 2 [(buf.validate.field).required = true]; | ||
// The id of the Organization that owns the Plugin that the Commit is associated with. | ||
string owner_id = 3 [ | ||
(buf.validate.field).required = true, | ||
(buf.validate.field).string.tuuid = true | ||
]; | ||
// The id of the Plugin that the Commit is associated with. | ||
string plugin_id = 4 [ | ||
(buf.validate.field).required = true, | ||
(buf.validate.field).string.tuuid = true | ||
]; | ||
// The Digest of the Commit's contents. | ||
Digest digest = 5 [(buf.validate.field).required = true]; | ||
// The id of the User that created this Commit on the BSR. | ||
// | ||
// May be empty if the User is no longer available. | ||
string created_by_user_id = 6 [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why or why not is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll add this field. I do have a question where this vcs url should come from?
For option 1 we're putting more work on the user because they don't have a readily available commit to use via the bufplugin-go sdk. They'd have to stamp this into the binary via a linker flag? Option 2 makes sense if we expose There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the answer to why or why not this field was not present in this PR already? This determines how you think about this solution. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I excluded it because it (initially) made less sense for plugins. For modules, you commit proto files, license, readme to vcs. There's a direct link between the committed files, a commit and the resulting contents pushed up to the BSR. The GitHub action pushes each vcs commit (regardless of proto changes) to the BSR. For plugins, you're typically not building and committing the compiled wasm module into vcs. And you're very unlikely to be publishing for every vcs commit, instead, you'd be doing a bunch of work on the plugin and when it's ready tag it and release. The model felt slightly different here. I agree we should add this field to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems to me that there's no reason to differentiate here - I would add |
||
(buf.validate.field).string.tuuid = true, | ||
(buf.validate.field).ignore = IGNORE_IF_UNPOPULATED | ||
]; | ||
// The URL of the source control commit that is associated with the Commit. | ||
// | ||
// BSR users can navigate to this link to find source control information that is relevant to this Commit | ||
// (e.g. commit description, PR discussion, authors, approvers, etc.). | ||
string source_control_url = 7 [ | ||
(buf.validate.field).string.uri = true, | ||
(buf.validate.field).string.max_len = 255, | ||
(buf.validate.field).ignore = IGNORE_IF_UNPOPULATED | ||
]; | ||
// The plugin info of the Commit. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make this a bit more. Something like "plugin information as stored directly within the plugin. This is part of the Bufplugin API, and can be returned from a plugin's GetPluginInfo implementation." |
||
buf.plugin.info.v1.PluginInfo info = 8; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
// Copyright 2023-2024 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package buf.registry.plugin.v1beta1; | ||
|
||
import "buf/registry/plugin/v1beta1/commit.proto"; | ||
import "buf/registry/plugin/v1beta1/digest.proto"; | ||
import "buf/registry/plugin/v1beta1/resource.proto"; | ||
import "buf/validate/validate.proto"; | ||
|
||
option go_package = "buf.build/gen/go/bufbuild/registry/protocolbuffers/go/buf/registry/plugin/v1beta1"; | ||
|
||
// Operate on Commits. | ||
service CommitService { | ||
// Get Commits. | ||
rpc GetCommits(GetCommitsRequest) returns (GetCommitsResponse) { | ||
option idempotency_level = NO_SIDE_EFFECTS; | ||
} | ||
// List Commits for a given Plugin, Label, or Commit. | ||
rpc ListCommits(ListCommitsRequest) returns (ListCommitsResponse) { | ||
option idempotency_level = NO_SIDE_EFFECTS; | ||
} | ||
} | ||
|
||
message GetCommitsRequest { | ||
// References to request a Commit for. | ||
// | ||
// See the documentation on ResourceRef for resource resolution details. | ||
// | ||
// Resolution is as follows: | ||
// - If a Plugin is referenced, the Commit of the default Label is returned. | ||
// - If a Label is referenced, the Commit of this Label is returned. | ||
// - If a Commit is referenced, this Commit is returned. | ||
repeated ResourceRef resource_refs = 1 [ | ||
(buf.validate.field).repeated.min_items = 1, | ||
(buf.validate.field).repeated.max_items = 250 | ||
]; | ||
// The DigestType to use for Digests returned on Commits. | ||
// | ||
// If this DigestType is not available, an error is returned. | ||
// Note that certain DigestTypes may be deprecated over time. | ||
// | ||
// If not set, the latest DigestType is used, currently p1. | ||
DigestType digest_type = 2 [(buf.validate.field).enum.defined_only = true]; | ||
} | ||
|
||
message GetCommitsResponse { | ||
// The found Commits in the same order as requested. | ||
repeated Commit commits = 1 [(buf.validate.field).repeated.min_items = 1]; | ||
} | ||
|
||
message ListCommitsRequest { | ||
// The list order. | ||
enum Order { | ||
ORDER_UNSPECIFIED = 0; | ||
// Order by create_time newest to oldest. | ||
ORDER_CREATE_TIME_DESC = 1; | ||
// Order by create_time oldest to newest. | ||
ORDER_CREATE_TIME_ASC = 2; | ||
} | ||
// The maximum number of items to return. | ||
// | ||
// The default value is 10. | ||
uint32 page_size = 1 [(buf.validate.field).uint32.lte = 250]; | ||
// The page to start from. | ||
// | ||
// If empty, the first page is returned. | ||
string page_token = 2 [(buf.validate.field).string.max_len = 4096]; | ||
// The reference to list Commits for. | ||
// | ||
// See the documentation on Ref for resource resolution details. | ||
// | ||
// Once the resource is resolved, the following Commits are listed (subject to any additional filters in the request): | ||
// - If a Plugin is referenced, all Commits for the Plugin are returned. | ||
// - If a Label is referenced, the Commit the Label points to is returned. | ||
// Use ListLabelHistory to get the history of Commits for a Label. | ||
// - If a Commit is referenced, this Commit is returned. | ||
ResourceRef resource_ref = 3 [(buf.validate.field).required = true]; | ||
// The order to return the Commits. | ||
// | ||
// If not specified, defaults to ORDER_CREATE_TIME_DESC. | ||
Order order = 4 [(buf.validate.field).enum.defined_only = true]; | ||
// The DigestType to use for Digests returned on Commits. | ||
// | ||
// If this DigestType is not available, an error is returned. | ||
// Note that certain DigestTypes may be deprecated over time. | ||
// | ||
// If not set, the latest DigestType is used, currently p1. | ||
DigestType digest_type = 5 [(buf.validate.field).enum.defined_only = true]; | ||
// Only return Commits with an id that contains this string using a case-insensitive comparison. | ||
string id_query = 6 [(buf.validate.field).string.max_len = 36]; | ||
} | ||
|
||
message ListCommitsResponse { | ||
// The next page token. | ||
// | ||
// If empty, there are no more pages. | ||
string next_page_token = 1 [(buf.validate.field).string.max_len = 4096]; | ||
// The listed Commits. | ||
repeated Commit commits = 2; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright 2023-2024 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package buf.registry.plugin.v1beta1; | ||
|
||
import "buf/validate/validate.proto"; | ||
|
||
option go_package = "buf.build/gen/go/bufbuild/registry/protocolbuffers/go/buf/registry/plugin/v1beta1"; | ||
|
||
// A digest of a Commit's content. | ||
// | ||
// A digest represents all content for a single Commit. | ||
message Digest { | ||
// The type of the Digest. | ||
DigestType type = 1 [ | ||
(buf.validate.field).required = true, | ||
(buf.validate.field).enum.defined_only = true | ||
]; | ||
// The value of the Digest. | ||
bytes value = 2 [(buf.validate.field).required = true]; | ||
} | ||
|
||
// The type of Digest. | ||
enum DigestType { | ||
DIGEST_TYPE_UNSPECIFIED = 0; | ||
// The p1 digest function. | ||
DIGEST_TYPE_P1 = 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extreme nit: I would sort these alphabetically, to match the lock file