Add initial specification for plugin support #126
Conversation
|
The latest Buf updates on your PR.
|
| option go_package = "buf.build/gen/go/bufbuild/registry/protocolbuffers/go/buf/registry/plugin/v1"; | ||
|
|
||
| // Operate on Plugins. | ||
| service PluginService { |
There was a problem hiding this comment.
Not sure if we're planning to bring in the ResolveService, but it'd be nice if we stubbed out a single RPC to resolve Generated SDK version. Something like
rpc ResolveGeneratedSDKVersion
rpc ResolveSDKVersion
Basically folding all the Get{Go,Swift,Maven,NPM,...}Version into a single RPC. You could argue that this fits nicely with the "PluginService".
There was a problem hiding this comment.
Ideally there's also an RPC to get a registry-specific package ID. Could be the same RPC.
| google.protobuf.Timestamp update_time = 3 [(buf.validate.field).required = true]; | ||
| // The name of the Plugin. | ||
| // | ||
| // Unique within a given User or Organization. |
There was a problem hiding this comment.
Does this imply that each version/revision of the plugin has a different name?
| // Semver-formatted release version of the Plugin. | ||
| string version = 3; | ||
| // The revision of the Plugin. This represents the BSR image version of the Plugin. | ||
| uint32 revision = 4; |
There was a problem hiding this comment.
Should these be under Name? Why would I want to specify these if I have the plugin ID?
|
Partially superseded by #132. TBD on code generation plugins, but this is the first milestone towards Check plugins. |
This PR is a work in progress, open questions need to be addressed before full review.