Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Prototype new GitHub workflows for push++ #105

Closed
wants to merge 1 commit into from

Conversation

nicksnyder
Copy link
Member

Creating a draft PR so it is easy to have discussions about and to inform decisions we are making with the unified GitHub action project.

@nicksnyder nicksnyder requested a review from emcfarlane April 30, 2024 00:12
run: buf format --diff --exit-code --error-format github-actions
- name: buf lint
run: buf lint --error-format github-actions
- name: buf push
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as currently implemented, push doesn't happen on a branch if build, format, or lint fail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to push even if lint and build fail?

Comment on lines +12 to +13
version: 1.32.0-beta.1 # remove this flag when 1.32.0 is released so we go back to always tracking latest.
# todo: use .bufversion or the env variable?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line could be deleted if the action already supported .bufversion, which is in the proposal, but not implemented by the current action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant