Skip to content

Commit

Permalink
Add CommitCheckStatus filter to ListLabelHistory (#80)
Browse files Browse the repository at this point in the history
This is helpful so the review flow UI can fetch only commits that are
pending on a label.
  • Loading branch information
nicksnyder authored Feb 29, 2024
1 parent 0971f26 commit 4b63e53
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions buf/registry/module/v1/label_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ message ListLabelHistoryRequest {
// TODO: We are purposefully not making the default the zero enum value, however
// we may want to consider this.
Order order = 4 [(buf.validate.field).enum.defined_only = true];
// Only return Commits that have one of these CommitCheckStatus values for this label.
//
// If not set, Commits with any CommitCheckStatus value are returned.
repeated CommitCheckStatus commit_check_statuses = 6 [(buf.validate.field).repeated.items.enum.defined_only = true];
}

message ListLabelHistoryResponse {
Expand Down
4 changes: 4 additions & 0 deletions buf/registry/module/v1beta1/label_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ message ListLabelHistoryRequest {
//
// If not set, the latest DigestType is used, currently B5.
DigestType digest_type = 5 [(buf.validate.field).enum.defined_only = true];
// Only return Commits that have one of these CommitCheckStatus values for this label.
//
// If not set, Commits with any CommitCheckStatus value are returned.
repeated CommitCheckStatus commit_check_statuses = 6 [(buf.validate.field).repeated.items.enum.defined_only = true];
}

message ListLabelHistoryResponse {
Expand Down

0 comments on commit 4b63e53

Please sign in to comment.