Clarify that protovalidate does not require any code generation #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pkwarren
reviewed
Nov 26, 2024
Co-authored-by: Philip K. Warren <[email protected]>
rodaine
approved these changes
Nov 26, 2024
rodaine
deleted the
tstamm/Clarify-that-protovalidate-does-not-require-any-code-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protoc-gen-validateis a plugin that generates validation code.protovalidateuses runtime libraries instead, and does not require code generation.This seems to be a frequent point of confusion for users when migrating. E.g. #275, #269, #177, #178, #73, #47.
I suggest we spell out this major difference in the main readme and the migration guide.