Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buf config to v2 #233

Closed
wants to merge 8 commits into from
Closed

Update buf config to v2 #233

wants to merge 8 commits into from

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Aug 1, 2024

Sets the buf version v1.35.0 explicitly. Runs buf config migrate. Runs buf format -w. Upgrades the bazel module to 0.3.0. Blocks #232

@rodaine
Copy link
Member

rodaine commented Aug 1, 2024

Not sure if managed modules can handle this yet since there are two modules in here. Cc @unmultimedio

@emcfarlane
Copy link
Contributor Author

Can push multiple v2 modules, modules without names are ignored.

@unmultimedio
Copy link
Member

Not sure if managed modules can handle this yet since there are two modules in here. Cc @unmultimedio

You can update here to v2 no problem, we don't support v2 in the managed modules repo yet, but we can do what we did for bufbuild/confluent by setting up a static buf.yaml v1: bufbuild/modules#579

@rodaine
Copy link
Member

rodaine commented Aug 1, 2024

I'm not sure that will work. There are two modules in here, and one depends on the other. A static buf.yaml won't work in that case.

@emcfarlane
Copy link
Contributor Author

Closing for now.

@emcfarlane emcfarlane closed this Aug 1, 2024
@unmultimedio
Copy link
Member

I'm not sure that will work. There are two modules in here, and one depends on the other. A static buf.yaml won't work in that case.

As long as there are no breaking changes it should work. The BSR syncer pulls information from all repos at the same time, but actually syncs them in dependency order, so as long as we say that pvt depends on pv, then pvt will grab the latest commit on the default label from pv which would be just synced. See this section:

To minimize issues with pinned dependencies on these modules, we sync them in the following order. First, we sync standalone modules. After they succeed, we then sync the modules that depend on them, which use the latest pushed dependency commit. As long as the dependencies don’t have any breaking change in the source code, this should be sufficient and stable for upstream modules.

https://github.com/bufbuild/modules?tab=readme-ov-file#how-we-handle-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants