Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments and documentation of examples #157

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix typos in comments and documentation of examples #157

merged 1 commit into from
Jan 25, 2024

Conversation

philsawicki
Copy link
Contributor

Committing changes to a few proto files located in the /examples folder, to mainly fix typos and spelling.

This changes aims to make it easier for contributors to adopt these samples into their own project, and increase the confidence in the accuracy of the validation framework by signaling that a review process of the examples has taken place.

@nicksnyder nicksnyder changed the title Fix typos in comments and documentation of examples. Fix typos in comments and documentation of examples Jan 25, 2024
Copy link
Member

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicksnyder nicksnyder merged commit ebbd81a into bufbuild:main Jan 25, 2024
3 of 4 checks passed
@philsawicki
Copy link
Contributor Author

@nicksnyder Thanks for reviewing and approving!

@philsawicki philsawicki deleted the dev/fix-proto-comment-typos branch January 26, 2024 01:25
stefanvanburen added a commit that referenced this pull request Jan 26, 2024
Similar to #157, using the [typos][1] tool. All the changes seem like
valid fixes.

Not sure if any of the filename changes are consumed downstream and thus
would break an import, though?

[1]: https://github.com/crate-ci/typos
stefanvanburen added a commit that referenced this pull request Jan 26, 2024
Similar to #157, using the [typos][1] tool. All the changes seem like
valid fixes.

Not sure if any of the filename changes are consumed downstream and thus
would break an import, though?

[1]: https://github.com/crate-ci/typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants