Skip to content

Commit

Permalink
Fixes for strict conformance with Editions (#226)
Browse files Browse the repository at this point in the history
I accidentally did not test with the `--strict*` flags set and left a
couple of copy-paste errors :( Oops!

This should now pass as expected with updated implementations.
  • Loading branch information
jchadwick-buf authored Jul 17, 2024
1 parent bb1d618 commit 5bbf2bf
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ func ignoreEmptySuite() suites.Suite {
},
"proto/2023/message/explicit_presence/length_prefixed/zero": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresence{Val: &cases.IgnoreEmptyEditionsMessageExplicitPresence_Msg{}},
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.proto2.message"}),
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.editions.message"}),
},
"proto/2023/message/explicit_presence/length_prefixed/unset": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresence{},
Expand All @@ -318,7 +318,7 @@ func ignoreEmptySuite() suites.Suite {
},
"proto/2023/message/explicit_presence/delimited/zero": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited{Val: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited_Msg{}},
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.proto2.message"}),
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.editions.message"}),
},
"proto/2023/message/explicit_presence/delimited/unset": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited{},
Expand Down

0 comments on commit 5bbf2bf

Please sign in to comment.