Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for messages with required fields #49

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

pkwarren
Copy link
Member

Currently, validation fails for proto 2 messages with required fields. Update the code which loads constraints for a message to use buildPartial() instead of parseFrom() to allow messages with required fields to work.

Fixes #41.

Currently, validation fails for proto 2 messages with required fields.
Update the code which loads constraints for a message to use
buildPartial() instead of parseFrom() to allow messages with required
fields to work.

Fixes #41.
@pkwarren pkwarren requested review from rodaine and Alfus October 16, 2023 22:15
@pkwarren pkwarren merged commit 5a018e5 into main Oct 16, 2023
3 checks passed
@pkwarren pkwarren deleted the pkw/issue-41 branch October 16, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Validator internally failing to construct a proto2 message that has required fields that aren't set
2 participants