Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement structured field and rule paths for violations #213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jchadwick-buf
Copy link
Member

@jchadwick-buf jchadwick-buf commented Nov 27, 2024

Implements the changes needed to pass conformance after bufbuild/protovalidate#265.

This is basically a straight port of what is done in bufbuild/protovalidate-go#154, owing to the similarities between protovalidate-go and protovalidate-java. Unfortunately this means it inherits some of the trickier maneuvers needed to weave the right data into the right places. This version is also not as efficient as a result of differences between Go and Java protobufs, but effort was made to try to prevent big regressions in the case of successful validation.

Some of this is probably not as pretty as it could be. I'm open to improvements if there are any obvious things (I am certainly not a Java expert after all) but if possible I'd like to defer anything that would require major rethinking to down the road. (Happy to add TODOs for those, though.)

DO NOT MERGE until the following is done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant