Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to protovalidate 0.6.1 #106

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Update to protovalidate 0.6.1 #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c15a889
Update to protovalidate 0.6.1
pkwarren Feb 13, 2024
7fb9e22
revert nullable changes
pkwarren Mar 5, 2024
45e1c1c
add overload tests
pkwarren Mar 5, 2024
2bd64b8
fix javadoc
pkwarren Mar 5, 2024
2191097
use more consistent phrasing
pkwarren Mar 5, 2024
7127c9d
add isDigit helper
pkwarren Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,10 @@ tasks.withType<JavaCompile> {
}

tasks.withType<Javadoc> {
// TODO: Enable when Javadoc changes are final
// val stdOptions = options as StandardJavadocDocletOptions
// stdOptions.addBooleanOption("Xwerror", true)
val stdOptions = options as StandardJavadocDocletOptions
stdOptions.addBooleanOption("Xwerror", true)
// Ignore warnings for generated code.
stdOptions.addBooleanOption("Xdoclint/package:-build.buf.validate,-build.buf.validate.priv", true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out how to ignore warnings on Javadoc for generated protoc code but still mark warnings as errors for our library code.

}

tasks.withType<GenerateModuleMetadata> {
Expand Down
762 changes: 762 additions & 0 deletions conformance/src/main/java/build/buf/validate/conformance/cases/IgnoreProto2Proto.java
View file
Open in desktop

Large diffs are not rendered by default.

647 changes: 647 additions & 0 deletions conformance/src/main/java/build/buf/validate/conformance/cases/IgnoreProto3Proto.java
View file
Open in desktop

Large diffs are not rendered by default.

Loading