Fix panic when using a repeated field as a predefined rule #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / validate-protos (pull_request).
|
Alfus
approved these changes
Sep 30, 2024
rodaine
added
the
Emergency Bypass Review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rodaine
removed
the
Emergency Bypass Review
|
Breaking changes are expected due to the transitive breaking changes from the protovalidate project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a repeated field as a predefined rule value results in a panic, as CEL cannot convert a
protoreflect.Listvalue into a valid CEL type. This results in an error value standing in for the list's value in the expression. When attempting to optimize the expression via computing residuals, a type assertion without the guard boolean (i.e.,typed := unknown.(T)instead oftyped, ok := unknown.(T)) triggers the panic on this non-list error value.This patch adds a new helper to the celext package to compute an appropriate value for any
protoreflect.Valuegiven its field descriptor.Fixes #148