Use Vitess's fork of goyacc, which uses more efficient token union type #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft because I don't want to actually merge in its current form.
We'd need to make a decision about whether to use
--fast-append
mode (an optimization intended to counter the fact that the use of an interface type means that non-pointer types are still allocated on the heap, including slices where the slice headers get allocated on the heap) or to wrap all of the slice types in the union in single-field structs (so the value in the interface is a pointer, and there won't be other unintentional allocations of non-pointer types).If we go with the former, the
"unsafe"
import is required. But that seems not-great for portability. However, the second approach doesn't immediately let us remove the"unsafe"
import until this bug is fixed.