Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Doc type and update PluginInfo #7

Merged
merged 1 commit into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions buf/plugin/info/v1/doc.proto

This file was deleted.

2 changes: 1 addition & 1 deletion buf/plugin/info/v1/license.proto
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ message License {

// The raw text of the license.
string text = 2;
// The url that contains the license
// The url that contains the license.
string url = 3 [
(buf.validate.field).ignore = IGNORE_IF_UNPOPULATED,
(buf.validate.field).string.uri = true
Expand Down
13 changes: 3 additions & 10 deletions buf/plugin/info/v1/plugin_info.proto
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,16 @@

package buf.plugin.info.v1;

import "buf/plugin/info/v1/doc.proto";
import "buf/plugin/info/v1/license.proto";
import "buf/validate/validate.proto";

option go_package = "buf.build/gen/go/bufbuild/bufplugin/protocolbuffers/go/buf/plugin/info/v1";

// Information about a plugin.
message PluginInfo {
// The url for the plugin.
// A long string providing more details on using the plugin.
//
// This typically is the source control repository that contains the plugin's implementation.
string url = 1 [
(buf.validate.field).ignore = IGNORE_IF_UNPOPULATED,
(buf.validate.field).string.uri = true
];
// This is equivalent to a README.md in effect.
string documentation = 1;

Check failure on line 28 in buf/plugin/info/v1/plugin_info.proto

View workflow job for this annotation

GitHub Actions / buf

Field "1" with name "documentation" on message "PluginInfo" changed option "json_name" from "url" to "documentation".

Check failure on line 28 in buf/plugin/info/v1/plugin_info.proto

View workflow job for this annotation

GitHub Actions / buf

Field "1" on message "PluginInfo" changed name from "url" to "documentation".
// The license of the plugin.
License license = 2;
// Documentation for a plugin.
Doc doc = 3;
}

Check failure on line 31 in buf/plugin/info/v1/plugin_info.proto

View workflow job for this annotation

GitHub Actions / buf

Previously present field "3" with name "doc" on message "PluginInfo" was deleted without reserving the name "doc".

Check failure on line 31 in buf/plugin/info/v1/plugin_info.proto

View workflow job for this annotation

GitHub Actions / buf

Previously present field "3" with name "doc" on message "PluginInfo" was deleted without reserving the number "3".
Loading