-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(permissions): add command permissions #169
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 217216a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this does technically work and will deploy, I'd like to add a bit more DX for it. Maybe passing an array from an enum of permissions?
Additionally, the subcommand and subcommand groups currently won't work. They don't error because they're still abstract within Carbon, but if you check the test command for them, you'll see the errors there.
Closes #155