-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance simple_update!
for MPS
in the Canonical
form
#255
Conversation
@mofeing @starsfordummies Maybe we should put the |
ok for me! |
@mofeing I refactored the |
nice! so I understand that if you don't provide the bond, then it normalizes all of them right? mmm do you have a use case for normalizing just 1 bond? |
So I did not implemented it like that but I will change it so it is like you said. Maybe a use case would be when you truncate, right? Since you only truncate a bond and thus you want to renormalize the only "perturbed" bond. |
I will do some more tests on |
that could be a case. in general you would want such a method in the case that you want to normalize 1 |
Okay for me this is ready to merge @starsfordummies @mofeing . I found that, in order to normalize all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, but can you check these comments?
https://github.com/bsc-quantic/Tenet.jl/pull/255/files#r1850557758
https://github.com/bsc-quantic/Tenet.jl/pull/255/files#r1850558850
also, on normalize!(::Canonical)
, doesn't just calling normalize!
individually on each
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 79.59% 0.04% -79.55%
==========================================
Files 32 32
Lines 2068 2072 +4
==========================================
- Hits 1646 1 -1645
- Misses 422 2071 +1649 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Okay, this was complicated... @mofeing @starsfordummies I finally managed to make everything work. For me, this makes sense. At least now, I think tomorrow I will forget for sure... Let's try to write it here: |
Summary
This PR refactors the$\Lambda$ tensors of an
simple_update!
function so now it properly uses theMPS
in theCanonical
form toevolve
the state without the need of recanonizing it.Additionally, we also added the
kwarg
ofnormalize
in thecanonize!
function.