Fix conj
to use deepcopy
instead of copy
#229
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we change
Base.conj
function to usedeepcopy
instead ofcopy
to prevent errors when manipulating tensor networks within an@unsafe_region
macro block.The regular
copy
leads to problem since it callsTensorNetworks(tensors(tn))
, which throws an error since there are inconsistent indices. Before the recent commit a241967 that refactored theconj
andadjoint
functions, we also had adeepcopy
insideconj
which prevent this problem.Example
With this PR, we can do something like the following code without any problem: