-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TensorNetwork
internals to incidence matrix representation
#120
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #120 +/- ##
===========================================
- Coverage 89.73% 87.76% -1.97%
===========================================
Files 10 10
Lines 604 564 -40
===========================================
- Hits 542 495 -47
- Misses 62 69 +7
☔ View full report in Codecov by Sentry. |
Elements of an `AbstractDict` have no guarantee to be in any order. This was affecting the order in which the `tensors` method was returning the tensors, and thus, doing weird things when computing the jacobian.
@jofrevalles Makie tests are now failing because now I return Would you mind looking at it? |
This PR refactors the
TensorNetwork
internals to be more like a incidence matrix.