Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TensorNetwork internals to incidence matrix representation #120

Merged
merged 13 commits into from
Nov 10, 2023

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Nov 6, 2023

This PR refactors the TensorNetwork internals to be more like a incidence matrix.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3424964) 89.73% compared to head (80181a2) 87.76%.

❗ Current head 80181a2 differs from pull request most recent head a2079e6. Consider uploading reports for the commit a2079e6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
- Coverage    89.73%   87.76%   -1.97%     
===========================================
  Files           10       10              
  Lines          604      564      -40     
===========================================
- Hits           542      495      -47     
- Misses          62       69       +7     
Files Coverage Δ
ext/TenetChainRulesTestUtilsExt.jl 100.00% <100.00%> (ø)
ext/TenetFiniteDifferencesExt.jl 100.00% <100.00%> (ø)
ext/TenetMakieExt.jl 100.00% <100.00%> (ø)
src/Transformations.jl 98.41% <100.00%> (+0.91%) ⬆️
ext/TenetChainRulesCoreExt.jl 75.00% <50.00%> (-4.32%) ⬇️
src/TensorNetwork.jl 74.52% <90.76%> (-5.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/Transformations_test.jl Show resolved Hide resolved
src/Transformations.jl Show resolved Hide resolved
Elements of an `AbstractDict` have no guarantee to be in any order. This was affecting the order in which the `tensors` method was returning the tensors, and thus, doing weird things when computing the jacobian.
@mofeing mofeing marked this pull request as ready for review November 9, 2023 12:54
@mofeing
Copy link
Member Author

mofeing commented Nov 9, 2023

@jofrevalles Makie tests are now failing because now I return tensors(tn) sorted by their inds (Look at the new definition of Tenet.tensors).

Would you mind looking at it?

@mofeing mofeing merged commit 4322b45 into develop Nov 10, 2023
2 of 3 checks passed
@mofeing mofeing deleted the refactor/tn-graph branch November 10, 2023 01:15
@mofeing mofeing restored the refactor/tn-graph branch September 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants