Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to get times from cyanite for Reader #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgran
Copy link
Contributor

@sgran sgran commented Oct 24, 2014

This makes an attempt to pull the information about metric interval validity from the cyanite backend, falling back to the current behavior if this request fails.

Signed-off-by: Stephen Gran [email protected]

@sgran
Copy link
Contributor Author

sgran commented Oct 24, 2014

I see that this is going to be harder with the way you're mocking things in the test. Not sure how to work around that just yet.

@brutasse
Copy link
Owner

The implementation makes sequential calls, which is probably going to introduce a pretty significant performance hit… We'd need to discuss this with @pyr but ideally these calls to cyanite should be batched.

@sgran
Copy link
Contributor Author

sgran commented Oct 28, 2014

Yeah, I had another thought about how to solve this in a cleaner way. Is there a good place where you and pyr and I can have a chat?

@sgran
Copy link
Contributor Author

sgran commented Oct 30, 2014

should we just discuss here? I was hoping for something a little more synchronous so we could bounce ideas back and forth, but this will do if nowhere else works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants