Update main.py #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a few updates regarding following issues-: - Error Handling: The code doesn’t handle possible errors, like if the file is missing or there’s an issue with parsing. This could cause it to crash when it encounters unexpected input. - Fixed Duration for Hold Notes: The code uses a fixed duration of 0.5 for hold notes, which might not be correct if the duration changes. It would be better to read the actual duration from the `.osu` file if available. - Parsing Hit Objects: The `.osu` file format can include other object types like sliders and spinners that have different formats. The code currently only works for basic hit objects and hold notes. - Unused Import: The `re` module is imported but isn’t used in the code. - Formatting* The generated Lua file could be cleaner by removing the extra comma after the last entry in the `Chart.Notes` list.
bruhstopbruhuhh
force-pushed
the
main
branch
28 times, most recently
from
2ba8a42
to
82b8c45
Compare
bruhstopbruhuhh
force-pushed
the
main
branch
30 times, most recently
from
7c2c6e1
to
d023e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few updates regarding following issues-:
Error Handling: The code doesn’t handle possible errors, like if the file is missing or there’s an issue with parsing. This could cause it to crash when it encounters unexpected input.
Fixed Duration for Hold Notes: The code uses a fixed duration of 0.5 for hold notes, which might not be correct if the duration changes. It would be better to read the actual duration from the
.osufile if available.Parsing Hit Objects: The
.osufile format can include other object types like sliders and spinners that have different formats. The code currently only works for basic hit objects and hold notes.Unused Import: The
remodule is imported but isn’t used in the code.Formatting* The generated Lua file could be cleaner by removing the extra comma after the last entry in the
Chart.Noteslist.