Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

[task_05] Add solution #239

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[task_05] Add solution #239

wants to merge 14 commits into from

Conversation

vinberoj24
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 6, 2023

📌 Duplicate code detection tool report

The tool analyzed your source code and found the following degree of similarity between the files:

trunk/II02302/task_02/src/qwerty.cpp

📄 trunk/II02302/task_02/src/qwerty.cpp

File Similarity (%)
trunk/ii02305/src/task_02.cpp 89.58
trunk/ii02305/src/task_02.cpp

📄 trunk/ii02305/src/task_02.cpp

File Similarity (%)
trunk/II02302/task_02/src/qwerty.cpp 89.58
trunk/ii02320/task_03/doc/readme.md

📄 trunk/ii02320/task_03/doc/readme.md

File Similarity (%)
trunk/ii02412/task_03/doc/readme.md 89.9
trunk/ii02408/task_03/src/main2.cpp

📄 trunk/ii02408/task_03/src/main2.cpp

File Similarity (%)
trunk/ii02414/task_03/src/main.cpp 89.08
trunk/ii02412/task_03/doc/readme.md

📄 trunk/ii02412/task_03/doc/readme.md

File Similarity (%)
trunk/ii02320/task_03/doc/readme.md 89.9
trunk/ii02414/task_03/src/main.cpp

📄 trunk/ii02414/task_03/src/main.cpp

File Similarity (%)
trunk/ii02408/task_03/src/main2.cpp 89.08

Copy link
Collaborator

@alkurash alkurash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправить конфликт с task_01. Его не должно быть в данном pull request

Copy link
Member

@idzm idzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Найденные ошибки должны быть в отдельных запросах. Они должны быть атомарными: одна ошибка - один вопрос (issue).
Также те предложения, которые можно реализовать, надо сразу оформлять в виде pull request. Например:

В функции Run, переменная m_filesCount не инициализирована перед использованием. Рекомендуется инициализировать переменные перед их использованием, чтобы избежать неопределенного поведения.

Что мешает это сразу предложить в PR?

@idzm idzm added bug Something isn't working question Further information is requested labels Dec 14, 2023
Copy link

sonarcloud bot commented Dec 26, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants