Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename custommMetrics() #55

Open
robertvazan opened this issue Jun 6, 2018 · 2 comments
Open

Rename custommMetrics() #55

robertvazan opened this issue Jun 6, 2018 · 2 comments
Milestone
2.1

Comments

@robertvazan
Copy link

Method name contains a typo. It should be customMetrics().
@tholu
Copy link

tholu commented Apr 18, 2019

@brsanthu Will you be maintaining this library? This would be a really easy fix and @robertvazan made some very good points for improvements in other issues as well.

Otherwise I would fork this permanently.

brsanthu added a commit that referenced this issue May 19, 2019
@brsanthu
Deprecate api with typo custommMetrics #55
3e4d516
@brsanthu brsanthu added this to the 2.1 milestone May 20, 2019
@brsanthu
Copy link
Owner

Old typoed api has been deprecated and add new in its place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@tholu @brsanthu @robertvazan