Deprecate api with typo custommMetrics #55

brsanthu · May 19, 2019 · 3e4d516 · 3e4d516
1 parent 930fb9a
commit 3e4d516
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/main/java/com/brsanthu/googleanalytics/internal/GoogleAnalyticsImpl.java b/src/main/java/com/brsanthu/googleanalytics/internal/GoogleAnalyticsImpl.java
@@ -291,11 +291,11 @@ protected void processCustomDimensionParameters(GoogleAnalyticsRequest<?> reques
      */
     protected void processCustomMetricParameters(GoogleAnalyticsRequest<?> request, HttpRequest req) {
         Map<String, String> customMetricParms = new HashMap<>();
-        for (String defaultCustomMetricKey : defaultRequest.custommMetrics().keySet()) {
-            customMetricParms.put(defaultCustomMetricKey, defaultRequest.custommMetrics().get(defaultCustomMetricKey));
+        for (String defaultCustomMetricKey : defaultRequest.customMetrics().keySet()) {
+            customMetricParms.put(defaultCustomMetricKey, defaultRequest.customMetrics().get(defaultCustomMetricKey));
         }
 
-        Map<String, String> requestCustomMetrics = request.custommMetrics();
+        Map<String, String> requestCustomMetrics = request.customMetrics();
         for (String requestCustomDimKey : requestCustomMetrics.keySet()) {
             customMetricParms.put(requestCustomDimKey, requestCustomMetrics.get(requestCustomDimKey));
         }

diff --git a/src/main/java/com/brsanthu/googleanalytics/request/GoogleAnalyticsRequest.java b/src/main/java/com/brsanthu/googleanalytics/request/GoogleAnalyticsRequest.java
@@ -306,10 +306,20 @@ public Map<String, String> customDimensions() {
         return customDimensions;
     }
 
+    /**
+     * This method name has typo hence has been deprecated.
+     *
+     * @deprecated please use {@link #customMetrics}
+     */
+    @Deprecated
     public Map<String, String> custommMetrics() {
         return customMetrics;
     }
 
+    public Map<String, String> customMetrics() {
+        return customMetrics;
+    }
+
     @Override
     public String toString() {
         StringBuilder builder = new StringBuilder();