Change deepClone to clone #52

brsanthu · May 20, 2019 · 6ac22c5 · 6ac22c5
1 parent fcf5f8f
commit 6ac22c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/com/brsanthu/googleanalytics/request/GoogleAnalyticsRequest.java b/src/main/java/com/brsanthu/googleanalytics/request/GoogleAnalyticsRequest.java
@@ -70,7 +70,7 @@
  * @author Santhosh Kumar
  */
 @SuppressWarnings("unchecked")
-public class GoogleAnalyticsRequest<T> {
+public class GoogleAnalyticsRequest<T> implements Cloneable {
 
     public static final String HIT_SCREENVIEW = "screenview";
     public static final String HIT_PAGEVIEW = "pageview";
@@ -1915,7 +1915,8 @@ public ZonedDateTime occurredAt() {
      * Deep clones this hit and returns new request of same type. Any changes made to this request after this call, will
      * not be reflected in the returned instance.
      */
-    public T deepClone() {
+    @Override
+    public T clone() {
         try {
             GoogleAnalyticsRequest<T> clonedReq = this.getClass().newInstance();
             clonedReq.occurredAt = ZonedDateTime.now();

diff --git a/src/test/java/com/brsanthu/googleanalytics/GoogleAnalyticsTest.java b/src/test/java/com/brsanthu/googleanalytics/GoogleAnalyticsTest.java
@@ -217,7 +217,7 @@ void testAutoQueueTimeBatch() throws Exception {
     @Test
     void testDeepClone() throws Exception {
         ScreenViewHit screenhit1 = ga.screenView().adwordsId("test1");
-        ScreenViewHit screenhit2 = screenhit1.deepClone();
+        ScreenViewHit screenhit2 = screenhit1.clone();
 
         screenhit1.adwordsId("test1updated");
 
@@ -259,7 +259,7 @@ void testAnyHit() throws Exception {
         anyhit1.adwordsId("adsid456");
         assertThat(sv.adwordsId()).isEqualTo(anyhit1.adwordsId());
 
-        AnyHit anyhit2 = sv.deepClone().asAnyHit();
+        AnyHit anyhit2 = sv.clone().asAnyHit();
         anyhit2.adwordsId("adsid789");
         assertThat(sv.adwordsId()).isNotEqualTo(anyhit2.adwordsId());
     }