Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets syntax errors #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix assets syntax errors #4

wants to merge 2 commits into from

Conversation

radanskoric
Copy link

Some css files are using:

filter: alpha(opacity:50)

That is incorrect css syntax. Instead, "opacity=50" should be used. If assets pipeline is enabled with Sass compiler it will throw an error during rake assets:precompile task. For example that prevents a project that uses it to be deployed to Heroku.

This pull requests fixes those occurences of opacity filter.

@radanskoric
Copy link
Author

Is there something I can do to get this merged in? Is there something wrong with the changesets?

Thank you in advance.

@iaddict
Copy link

iaddict commented Jul 6, 2013

+1 for this patch

Please merge, otherwise this plugin is rather unusable on production systems where the assets need to be precompiled. The precompiler fails awfully because of the syntax errors.

Thanks!

@micred
Copy link

micred commented Jan 22, 2014

+1

1 similar comment
@rordeix
Copy link

rordeix commented Feb 18, 2014

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants