Database events #209
Database events #209
Conversation
|
Draft until tests for database copy and rename are added. These events are not new signals, but should be a combination of existing signals, and should just work™️, but need to be tested first. You don't have to love this code, BTW 😛. But making it much better would require refactoring... Too a while because this is a totally different way of saving and interacting with the data, no SQLite here (yet). |
bw2data/project.py
Outdated
| try: | ||
| delta = revisions.generate_delta(old, new, operation) | ||
| except NoRevisionNeeded: | ||
| return |
There was a problem hiding this comment.
Why do we raise if we then just ignore it? Would it be better for the execution flow to just return None and act here accordingly?
There was a problem hiding this comment.
Made this change in 3728040, but I don't love it - I find it cleaner to have the functions always have a single return signature. In any case it should be fixed now.
|
Ready for review |
cmutel
force-pushed
the
database-events
branch
from
9896bf1
to
ef15886
Compare
|
Rebased after #207 was merged. |
|
Moved back to draft after some tests are now failing. |
No description provided.