LPS-189491 Replace Collapse by ClayPanel #139109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-control-menu-web
…SED and PageEditor#FRAGMENT_SIDEBAR_COLLECTION_PANEL_EXPANDED paths
…XT_ALIGN_ICON paths
…tAdvancedSettings and ContentPagesUI#ViewCollapseStyleInFragmentConfiguration tests
|
Closing pull request because all |
|
In order to not clog up ci resources, I'm sending the PR directly. The failure tests are unrelated to this PR (comparison with acceptance routine here). See liferay-echo#13221 ✔️ ci:test:stable - 29 out of 29 jobs passed |
|
ci:reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear frontend reviewer,
There are several things that the
ClayPanelcomponent doesn't have by default, such as ac-innerand styles defined in Lexicon. I have opened a question here liferay/clay#5624 for Clay and we have to wait for it to be solved before merging this code.cc.: @veroglez