Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up compilation #256

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Speed up compilation #256

wants to merge 3 commits into from

Conversation

SudeshnaBora
Copy link
Contributor

Related to #179

@SudeshnaBora SudeshnaBora self-assigned this Sep 29, 2021
@denisalevi
Copy link
Member

  1. You seem to have used the version that was used for the consistency tests (that means with TimedArray implementations of the randomness). Not sure what the effect is on compile times due to curand etc.
  2. And it seems you used a different script for brian2genn? In fact, you used one without TimedArray for brian2genn? You need to use the exact same script if you want to make things comparable.
  3. Please don't add large files to the repository. This PR tried to add 80MB of files to this repository, which doubles the current repository size. This just makes things super slow. Most of the size comes from the arrays saved in all the results directory. Those you don't need at all, please don't add them to the repository. And the TimedArray implementations store the arrays in the static_arrays folders. Those alone take up 20MB.

TODOs:

  1. How much work is it to repeat the merge for a script that doesn't use TimedArrays? If you think this is done in ~10min, please do that. If you have to manually merge everything again, just leave it as is. Then we will just not merge the branch.
  2. Either way, please make sure that the script for brian2cuda and brian2genn are the same (either brian2cuda without TimedArray or brian2gen with TimedArray)
  3. If you got rid of the TimedArrays, please create a new PR where only source files are added (no resulst folders). If recreating the script without TimedArray takes too much time, don't worry about this. We won't merge this PR in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants