validate strict configuration is possible #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
respect list of symbols
Strict config validation
|
@dillonstreator are you able to rebase this change and remove the style changes? Otherwise this PR looks good to me. |
|
rebased and reverted styles |
|
@dillonstreator sorry, I don't think I was clear: could you rebase to master? I can't merge this as is as there are conflicts. |
|
@brendanashworth sorry about that, think we're good now. LMK if something seems off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
This PR will perform validation on strict options and prevent overflowing callstack on invalid configuration