Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated virtual functions from using-declarations #968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZedThree
Copy link

struct Base {
  /// Zero arg impl
  virtual int foo() { return 42; };
  /// One arg impl
  virtual int foo(int x) { return x; };
};

struct Derived : public Base {
  using Base::foo;
  /// One arg override
  int foo(int x) override { return x + 1; }
};

This snippet generates duplicate declaration warnings in Sphinx, ultimately due to an issue in Doxygen. This PR cleans up the member list by checking if multiple members reimplement the same refid, and removes duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant