Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages not on conda-forge are now optional dependencies #11

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

willGraham01
Copy link
Collaborator

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Some BrainGlobe packages are not yet available on conda-forge, and thus we cannot put this meta-package on conda-forge yet.

Pending an upload of the missing dependencies, we can turn them into optional dependencies for the time being which will allow us to get the "base" package onto conda-forge.

What does this PR do?
cellfinder and morphapi are now optional dependencies, and can be specified when pip-installing.

References

How has this PR been tested?

Testing via upload to testpypi and clean install into a conda environment.

Is this a breaking change?

Kind of - installation now requires optional dependencies to reach the same state as v.0.0.0. But otherwise all existing scripts/workflows will be backwards compatible.

Does this PR require an update to the documentation?

README.md has been updated to reflect these changes. Overall documentation doesn't need to change.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +8.18 🎉

Comparison is base (c02e162) 81.81% compared to head (2b6a2eb) 90.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   81.81%   90.00%   +8.18%     
==========================================
  Files           1        1              
  Lines          11       20       +9     
==========================================
+ Hits            9       18       +9     
  Misses          2        2              
Impacted Files Coverage Δ
brainglobe/__init__.py 90.00% <100.00%> (+8.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamltyson
Copy link
Member

@willGraham01 it's definately worth getting cellfinder on coda-forge. It will be a while before we fully get rid of it. It's pure Python, and I think all of it's dependencies are on conda-forge so it shouldn't be too tricky.

@willGraham01
Copy link
Collaborator Author

willGraham01 commented Jun 21, 2023

@willGraham01 it's definately worth getting cellfinder on coda-forge. It will be a while before we fully get rid of it. It's pure Python, and I think all of it's dependencies are on conda-forge so it shouldn't be too tricky.

I have a staged recipe ready to go: conda-forge/staged-recipes#23116.

We just need multiprocessing-logging to bump their version on conda-forge up to v0.3.4 - they have an open PR on their feedstock but it's not merged yet.

Once that's done, I'll open another PR which'll make cellfinder part of the base package again.

@willGraham01 willGraham01 requested a review from a team June 21, 2023 10:10
@adamltyson adamltyson merged commit d17b34b into main Jun 21, 2023
@adamltyson adamltyson deleted the optionals-not-on-conda-forge branch June 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants