Packages not on conda-forge are now optional dependencies #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Some BrainGlobe packages are not yet available on conda-forge, and thus we cannot put this meta-package on conda-forge yet.
Pending an upload of the missing dependencies, we can turn them into optional dependencies for the time being which will allow us to get the "base" package onto conda-forge.
What does this PR do?
cellfinder
andmorphapi
are now optional dependencies, and can be specified whenpip
-installing.cellfinder
is nominated for removal anyway, so this package may simply be removed in a future update (see Simplifying the BrainGlobe (meta-)package structure for users and developers BrainGlobe#20)morphapi
is being worked on as permorphapi
external dependency is not available onconda-forge
#9.References
morphapi
external dependency is not available onconda-forge
#9 | CommentHow has this PR been tested?
Testing via upload to testpypi and clean install into a conda environment.
Is this a breaking change?
Kind of - installation now requires optional dependencies to reach the same state as
v.0.0.0
. But otherwise all existing scripts/workflows will be backwards compatible.Does this PR require an update to the documentation?
README.md has been updated to reflect these changes. Overall documentation doesn't need to change.
Checklist: